feat(storefront): strf-9921 Hide logging for successful internal API …

…calls in Stencil CLI: (#1033)

feat(storefront): strf-9921 Hide logging for successful internal API calls in Stencil CLI

BREAKING CHANGE: logging for successful internal API calls has been removed.

lib/StencilCLISettings.js

@@ -1,7 +1,7 @@
 class StencilCLISettings {
     constructor() {
         // The setting enables/disables verbose network requests logging
-        this.versboseNetworkLogging = true;
+        this.versboseNetworkLogging = false;
         // Enables usage of node sass fork for testing purposes
         this.oldNodeSassFork = false;
     }
@@ -11,7 +11,7 @@ class StencilCLISettings {
     }
 
     isVerbose() {
-        return this.versboseNetworkLogging === true;
+        return this.versboseNetworkLogging;
     }
 
     useOldNodeSassFork(flag) {

lib/StencilCLISettings.spec.js

@@ -3,15 +3,15 @@ const stencilCLISettings = require('./StencilCLISettings');
 describe('StencilCLISettings', () => {
     afterEach(() => {
         // setting to default
-        stencilCLISettings.setVerbose(true);
+        stencilCLISettings.setVerbose(false);
     });
 
-    it('should set network logging to verbose by default', () => {
-        expect(stencilCLISettings.isVerbose()).toBeTruthy();
+    it('should set network logging to non-verbose by default', () => {
+        expect(stencilCLISettings.isVerbose()).toBeFalsy();
     });
 
-    it('should set network logging to NOT verbose', () => {
-        stencilCLISettings.setVerbose(false);
-        expect(stencilCLISettings.isVerbose()).toBeFalsy();
+    it('should set network logging to verbose', () => {
+        stencilCLISettings.setVerbose(true);
+        expect(stencilCLISettings.isVerbose()).toBeTruthy();
     });
 });

lib/cliCommon.js

@@ -87,7 +87,7 @@ function checkNodeVersion() {
 function applyCommonOptions(program) {
     program
         .option('-h, --host [hostname]', 'specify the api host')
-        .option('-nov, --no-verbose', 'supress verbose info logging', false)
+        .option('-vb, --verbose', 'enable verbose info logging', false)
         .option(
             '--use-old-node-sass-fork',
             'use old node sass fork for scss compilation during bundling',

lib/utils/NetworkUtils.spec.js

@@ -224,7 +224,7 @@ describe('NetworkUtils', () => {
     });
 
     describe('log', () => {
-        it('should log the upcoming request', async () => {
+        it('should not log the upcoming request', async () => {
             const axiosMock = jest.fn();
             const httpsAgentMock = jest.fn();
             const packageInfoMock = {
@@ -247,9 +247,7 @@ describe('NetworkUtils', () => {
                 accessToken,
             });
 
-            expect(loggerMock.info).toHaveBeenCalledWith(
-                `Upcoming request ${`GET`.green}: ${url.green}`,
-            );
+            expect(loggerMock.info).not.toHaveBeenCalled();
         });
     });
 });