Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback for “Customers” #620

Open
sshaw opened this issue Oct 31, 2024 · 2 comments
Open

Feedback for “Customers” #620

sshaw opened this issue Oct 31, 2024 · 2 comments

Comments

@sshaw
Copy link

sshaw commented Oct 31, 2024

https://developer.bigcommerce.com/docs/rest-management/customers#get-all-customers:

date_created:min in query - string
Filter items by date created for example, 2024-05-14T09:34:00 or 2024-05-14. Returns metafields created after this date.

It says "Returns metafields" but it returns customers.

Also worth noting that the date string must not be URI nor form encoded. For example:

2024-10-19T20%3A00%3A00-0400

Won't work, one must use:

2024-10-19T20:00:00-0400

Maybe a bug but if this is an API-wide rule (I just checked with customers) should probably be mentioned here: https://developer.bigcommerce.com/docs/start/about/common-query-params

@bc-traciporter
Copy link
Collaborator

Hello @sshaw You found a mistake I made while cutting and pasting the date_created:min description. I fixed this in PR 621.

As far as the date format examples provided, the examples work.
Screenshot 2024-10-31 at 10 01 58 AM

bc-traciporter added a commit that referenced this issue Oct 31, 2024
<!-- Ticket number or summary of work -->
# [Issue-620](#620)


## What changed?
Correcting a cut and paste error, changed metafields to customers

## Release notes draft

Bug Fix
<!-- Provide an entry for the release notes using simple, conversational
language. Don't be too technical. Explain how the change will benefit
the merchant and link to the feature.

Examples:
* The newly-released [X feature] is now available to use. Now, you’ll be
able to [perform Y action].
* We're happy to announce [X feature], which can help you [perform Y
action].
* [X feature] helps you to create [Y response] using the [Z query
parameter]. Now, you can deliver [ex, localized shopping experiences for
your customers].
* Fixed a bug in the [X endpoint]. Now the [Y field] will appear when
you click [Z option]. -->
* 

## Anything else?
<!-- Add related PRs, salient notes, additional ticket numbers, etc. -->

ping {names}
@sshaw
Copy link
Author

sshaw commented Nov 2, 2024

As far as the date format examples provided, the examples work.

Yes but the date string must not be URI nor form encoded. You can encoded date_created:min to date_created%3Amin and it still works. You can encode any of the parameters the API endpoint accepts. But you must not encode the date value else the request does not return the proper results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants