-
Notifications
You must be signed in to change notification settings - Fork 221
feat(payment): Added BCP FL 3DS #2922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(payment): Added BCP FL 3DS #2922
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ code/snyk check is complete. No issues have been found. (View Details) |
b30a185
to
25d2ef8
Compare
import { | ||
LiabilityShiftEnum, | ||
threeDSecureParameters, | ||
} from '@bigcommerce/checkout-sdk/paypal-commerce-utils'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interfaces should be taken from bigcommerce-payments-utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -30,9 +32,14 @@ import { | |||
import BigCommercePaymentsRequestSender from '../bigcommerce-payments-request-sender'; | |||
|
|||
import { WithBigCommercePaymentsFastlanePaymentInitializeOptions } from './bigcommerce-payments-fastlane-payment-initialize-options'; | |||
import { LiabilityShiftEnum } from '../bigcommerce-payments-types'; | |||
import { isExperimentEnabled } from '@bigcommerce/checkout-sdk/utility'; | |||
import { PayPalFastlaneSdk } from '@bigcommerce/checkout-sdk/paypal-commerce-utils'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import PayPalFastlaneSdk from bigcommerce-payments-utils package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
a1e3fe0
to
4accc50
Compare
4accc50
to
0db0c54
Compare
What?
Added BCP FL 3DS implementation
Why?
To be able to use 3DSecure functionality
Testing / Proof
Unit tests
@bigcommerce/team-checkout @bigcommerce/team-payments