feat(orders): ORDERS-5715 add OrderFee interface, add fees field to Order interface #2066
Conversation
packages/core/src/order/order.ts
Outdated
| @@ -34,6 +34,15 @@ export default interface Order { | |||
| taxes: Tax[]; | |||
| taxTotal: number; | |||
| channelId: number; | |||
| fees?: OrderFee[]; | |||
There was a problem hiding this comment.
Is this supposed to an optional?
There was a problem hiding this comment.
I marked it as optional because fees are only included by default when coming from api/storefront/orders/ if PROJECT-5577.support_order_level_fee is on.
I suppose that the field itself should always be in the payload (even if it's just an empty array), so it should be fine to have as mandatory.
There was a problem hiding this comment.
I think that makes sense to mark it mandatory.
There was a problem hiding this comment.
Marked as mandatory now.
|
@matt-evangelidis For commit validation the scope needs to be |
matt-evangelidis
force-pushed
the
ORDERS-5715
branch
from
09a9b65 to
68c2cc2
Compare
matt-evangelidis
force-pushed
the
ORDERS-5715
branch
from
68c2cc2 to
5377051
Compare
|
|
@animesh1987 I don't have write access to this repo. Are you alright to merge? |
What?
This PR adds an
OrderFeeinterface and afeesfield to theOrderinterface inorder.ts.Why?
This adds some interfaces for fees specific to the Orders domain to provide separation between Checkout and Orders, as each domain's definitions of fees are likely to drift further apart over time.
Testing / Proof
N/A
@bigcommerce/team-checkout @bigcommerce/team-orders