Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(payment): PAYPAL-2719 fix amazon pay button for buy now flow #2052

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

bc-nick
Copy link
Contributor

@bc-nick bc-nick commented Jul 10, 2023

What?

Fix Amazon Pay button for buy now flow on PDP

Why?

To keep up-to-date data during the quota creation process

Testing / Proof

amazon.mov

@bigcommerce/team-checkout @bigcommerce/team-payments

@bc-nick bc-nick changed the title fix(payment): PAYPAL-2719 fix amazon pay button fix(payment): PAYPAL-2719 fix amazon pay button | buy now flow Jul 10, 2023
@bc-nick bc-nick changed the title fix(payment): PAYPAL-2719 fix amazon pay button | buy now flow fix(payment): PAYPAL-2719 fix amazon pay button for buy now flow Jul 10, 2023
@bc-nick bc-nick marked this pull request as ready for review July 10, 2023 12:24
@bc-nick bc-nick requested a review from a team as a code owner July 10, 2023 12:24
@bc-peng
Copy link
Contributor

bc-peng commented Jul 12, 2023

Can I know if you had the chance to test the changes on the cart page?
The reason I ask is that this code is shared there, and we had a previous incident where the cart page was breaking without our knowledge. It would be great if we could double-check to ensure it is working as expected.

@bc-nick
Copy link
Contributor Author

bc-nick commented Jul 12, 2023

Can I know if you had the chance to test the changes on the cart page? The reason I ask is that this code is shared there, and we had a previous incident where the cart page was breaking without our knowledge. It would be great if we could double-check to ensure it is working as expected.

@bc-peng these changes only for Buy Now Flow on PDP and don't affect the general logic of the button elsewhere. i tested on the integration store and ensure everything works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants