chore(common): CHECKOUT-6591 Set node version to 14 for repo #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
animesh1987
force-pushed
the
CHECKOUT-6591
branch
5 times, most recently
from
4f9777b to
7c0b160
Compare
animesh1987
changed the title
|
Could you update .nvmrc too? |
animesh1987
force-pushed
the
CHECKOUT-6591
branch
from
7c0b160 to
e3f6e6a
Compare
davidchin
reviewed
Apr 14, 2022
.nvmrc
Outdated
| @@ -1 +1 @@ | |||
| 10 | |||
| 14 | |||
There was a problem hiding this comment.
Suggested change
| 14 | |
| 14.18 |
To match with the version we're using in CircleCI
package.json
Outdated
| "homepage": "https://github.com/bigcommerce/checkout-sdk-js", | ||
| "scripts": { | ||
| "prepare": "check-node-version --node '>=6' --npm '>=6'", | ||
| "prepare": "check-node-version --node '>=14' --npm '>=6'", |
There was a problem hiding this comment.
Suggested change
| "prepare": "check-node-version --node '>=14' --npm '>=6'", | |
| "prepare": "check-node-version --node '>=14.18' --npm '>=6'", |
| @@ -246,6 +246,24 @@ describe('MonerisPaymentStrategy', () => { | |||
| }); | |||
|
|
|||
| describe('#execute', () => { | |||
| it('throws error when moneris response is not successful', async () => { | |||
There was a problem hiding this comment.
Do we need this change? It seems you just moved the it block to the top?
There was a problem hiding this comment.
Yes there is an issue how these tests are written, as postmessage payload was not leaking through tests and it was having intermittent behaviour. So I moved this one to top, and that fixed the issue. Once this is merged I will ping the integrations team to have a look as to what exactly was causing the issue with the test.
animesh1987
force-pushed
the
CHECKOUT-6591
branch
from
e3f6e6a to
dc81474
Compare
davidchin
approved these changes
Apr 14, 2022
animesh1987
force-pushed
the
CHECKOUT-6591
branch
from
dc81474 to
e6a6d90
Compare
orecio-bc
pushed a commit
to orecio-bc/checkout-sdk-js
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update node version of sdk
Why?
Before we start the next project, it's better to update to a newer node version
Testing / Proof
@bigcommerce/checkout