Skip to content

feat(payment): Stripe Link V2 loading indicator added #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

bc-dronov
Copy link
Contributor

What?

Passing loading container id to the Stripe Link V2 customer strategy
Related PR:
bigcommerce/checkout-sdk-js#2921

Why?

Because we need to show loading indicator during the payment process

Testing / Proof

Manual testing

@bc-dronov bc-dronov requested a review from a team as a code owner July 9, 2025 11:45
@bcsnyk
Copy link
Contributor

bcsnyk commented Jul 9, 2025

🎉 Snyk checks have passed. No issues have been found so far.

code/snyk check is complete. No issues have been found. (View Details)

@bc-dronov bc-dronov force-pushed the feat/stripe_linkv2_loading_indicator branch from 376712c to 53b9f86 Compare July 10, 2025 09:29
@bc-dronov bc-dronov requested review from a team as code owners July 10, 2025 09:29
@bc-dronov bc-dronov force-pushed the feat/stripe_linkv2_loading_indicator branch from 53b9f86 to 430e21a Compare July 10, 2025 09:32
@bc-dronov bc-dronov merged commit f2bae94 into master Jul 10, 2025
11 checks passed
@bc-dronov bc-dronov deleted the feat/stripe_linkv2_loading_indicator branch July 10, 2025 09:50
@bc-launchbay
Copy link

checkout-js deployed to Integration US
success 20250710101247 by Launchbay

@bc-launchbay
Copy link

checkout-js deployed to Staging US
success 20250710101247 by Launchbay

Copy link

⚡️ Lighthouse results

🖥️ Desktop:

Category Score
🟠 Performance 72
🟢 Accessibility 91
🟠 Best practices 78

📱 Mobile:

Category Score
🔴 Performance 42
🟢 Accessibility 94
🟠 Best practices 78

@bc-launchbay
Copy link

checkout-js deployed to Production US
success 20250710101247 by Launchbay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants