Skip to content

fix(payment): Make payment method title icon more readable for the sc… #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vitalii-koshovyi
Copy link
Contributor

@vitalii-koshovyi vitalii-koshovyi commented Jul 9, 2025

…reen readers

What?

Make payment method title icon more readable for the screen readers

Why?

All input fields under the payment section should only be announced once by screen reader.
However, they are announced twice for the Adyen.
The reason of it is a icon alt attribute, that sets to the methodName. I've added icon word to the alt attribute for more understandable reading.
image

Testing / Proof

image

@bcsnyk
Copy link
Contributor

bcsnyk commented Jul 9, 2025

🎉 Snyk checks have passed. No issues have been found so far.

code/snyk check is complete. No issues have been found. (View Details)

@vitalii-koshovyi vitalii-koshovyi marked this pull request as ready for review July 9, 2025 07:50
@vitalii-koshovyi vitalii-koshovyi requested a review from a team as a code owner July 9, 2025 07:50
@vitalii-koshovyi vitalii-koshovyi merged commit 57f7ce7 into bigcommerce:master Jul 9, 2025
8 checks passed
@bc-launchbay
Copy link

checkout-js deployed to Integration US
success 20250709084331 by Launchbay

@bc-launchbay
Copy link

checkout-js deployed to Staging US
success 20250709084331 by Launchbay

Copy link

github-actions bot commented Jul 9, 2025

⚡️ Lighthouse results

🖥️ Desktop:

Category Score
🟠 Performance 82
🟢 Accessibility 91
🟠 Best practices 78

📱 Mobile:

Category Score
🔴 Performance 42
🟢 Accessibility 94
🟠 Best practices 78

@bc-launchbay
Copy link

checkout-js deployed to Production US
success 20250709084331 by Launchbay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants