fix(core): conditionally include optional SEO metadata#2898
Merged
fix(core): conditionally include optional SEO metadata#2898
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 990161e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
095d696 to
57b99df
Compare
chanceaclark
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Conditionally include optional SEO metadata fields in
generateMetadataacross page files. Fieldsdescription,keywords, andalternatesare now only included in the returned metadata object when they have a value, using spread syntax (...(value && { key: value })). Previously, these fields were always set — potentially assigningnullor an empty string — which could cause Next.js to render empty<meta>tags.Testing
Unlighthouse report

Migration steps
Update
generateMetadatain the following pages to use conditional spread syntax for optional metadata fields:brand, category, webpages (contact + normal)
return { title: pageTitle || entity.name, - description: metaDescription, - keywords: metaKeywords ? metaKeywords.split(',') : null, + ...(metaDescription && { description: metaDescription }), + ...(metaKeywords && { keywords: metaKeywords.split(',') }), };For
brand/[slug]/page.tsx, also guard thealternatesfield:blog/[blogId]/page.tsx
return { title: pageTitle || blogPost.name, - description: metaDescription, - keywords: metaKeywords ? metaKeywords.split(',') : null, + ...(metaDescription && { description: metaDescription }), + ...(metaKeywords && { keywords: metaKeywords.split(',') }), ...(blogPost.path && { alternates: await getMetadataAlternates({ path: blogPost.path, locale }), }), };blog/page.tsx
Extract the description to a variable and spread conditionally: