fix(catalyst): Fix WishlistDetails page from exceeding complexity limit, fix e2e tests#2820
Merged
jordanarldt merged 1 commit intocanaryfrom Jan 12, 2026
Merged
fix(catalyst): Fix WishlistDetails page from exceeding complexity limit, fix e2e tests#2820jordanarldt merged 1 commit intocanaryfrom
jordanarldt merged 1 commit intocanaryfrom
Conversation
🦋 Changeset detectedLatest commit: 85fd334 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bde7f0c to
3eada96
Compare
3eada96 to
8e317a2
Compare
8e317a2 to
178d9da
Compare
…it, fix e2e tests
178d9da to
85fd334
Compare
jorgemoya
approved these changes
Jan 12, 2026
jamesqquick
pushed a commit
that referenced
this pull request
Feb 11, 2026
…it, fix e2e tests (#2820)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Fix the
account/wishlist/[id]pages from exceeding the GraphQL complexity limit. There was a PR authored previously that added additional data to theProductCardFragmentwhich ended up breaking the Wishlist Details page.Testing
Manual testing, automated e2e tests
All e2e tests for wishlists pass:

Migration
Step 1: Update wishlist GraphQL fragments
In
core/components/wishlist/fragment.ts, replace theWishlistItemProductFragmentto use explicit fields instead ofProductCardFragment:Remove
ProductCardFragmentfrom all fragment dependencies in the same file.Step 2: Update product card transformer
In
core/data-transformers/product-card-transformer.ts:Import the
WishlistItemProductFragment:Update the
singleProductCardTransformerfunction signature to accept both fragment types:Add a conditional check for the
inventoryMessagefield:Update the
productCardTransformerfunction signature similarly:Step 3: Fix wishlist e2e tests
In
core/tests/ui/e2e/account/wishlists.spec.ts, update label selectors to use{ exact: true }for specificity:Update all locators for the wishlist name input selectors:
Step 4: Fix mobile wishlist e2e tests
In
core/tests/ui/e2e/account/wishlists.mobile.spec.ts, update translation calls to use namespace prefixes: