Skip to content

[Catalyst 1677] Dont reset login form data #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesqquick merged 6 commits into from
Jan 14, 2026
Merged

[Catalyst 1677] Dont reset login form data #2819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ba9b40e
Add preventDefault to login form to prevent resetting of form on fail…
jamesqquick Jan 9, 2026
6bfcd30
added changeset
jamesqquick Jan 9, 2026
73af2c7
Merge branch 'canary' into CATALYST-1677-dont-reset-login-form-data
jamesqquick Jan 12, 2026
4670d4e
Merge branch 'canary' into CATALYST-1677-dont-reset-login-form-data
jamesqquick Jan 12, 2026
37e8abd
Merge branch 'canary' into CATALYST-1677-dont-reset-login-form-data
jamesqquick Jan 13, 2026
b62f857
remove passing of action to form since actions is called manually in …
jamesqquick Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thirty-coins-look.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@bigcommerce/catalyst-core": patch
---

The login form input data will no longer reset on a failed login attempt.
10 changes: 8 additions & 2 deletions core/vibes/soul/sections/sign-in-section/sign-in-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import { getFormProps, getInputProps, SubmissionResult, useForm } from '@conform-to/react';
import { getZodConstraint, parseWithZod } from '@conform-to/zod';
import { useActionState, useEffect } from 'react';
import { startTransition, useActionState, useEffect } from 'react';
import { useFormStatus } from 'react-dom';

import { FormStatus } from '@/vibes/soul/form/form-status';
Expand Down Expand Up @@ -37,6 +37,12 @@ export function SignInForm({
constraint: getZodConstraint(schema),
shouldValidate: 'onBlur',
shouldRevalidate: 'onInput',
onSubmit(event, { formData }) {
event.preventDefault();
Copy link
Contributor

@matthewvolk matthewvolk Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍹 I could be wrong, but I think preventDefault() allows us to remove the action={formAction} attribute on the form element below. Since we're now calling it here in onSubmit, I think the action prop is redundant. Double check me on that.

Copy link
Contributor Author

@jamesqquick jamesqquick Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to remove passing the action!

startTransition(() => {
formAction(formData);
});
},
onValidate({ formData }) {
return parseWithZod(formData, { schema });
},
Expand Down Expand Up @@ -70,7 +76,7 @@ export function SignInForm({
};

return (
<form {...getFormProps(form)} action={formAction} className="flex grow flex-col gap-5">
<form {...getFormProps(form)} className="flex grow flex-col gap-5">
<Input
{...getInputProps(fields.email, { type: 'text' })}
errors={fields.email.errors}
Expand Down