fix(core): delete duplicate select component#2813
Conversation
🦋 Changeset detectedLatest commit: ea5f21b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
chanceaclark
left a comment
There was a problem hiding this comment.
I fully forget why we did it, but I remember having two "Selects" was intentional based on this PR #2326 Do we want to keep the two still or does it make sense to deduplicate based on that PR?
Good callout @chanceaclark. I can't see a reason to separate these, maybe @hunterbecton can provide some context. |
|
@chanceaclark I just noticed that at some point, the We can keep just one ( |
|
I believe the |
With the removal of |
I don't recall why we have a separate |
hunterbecton
left a comment
There was a problem hiding this comment.
I don't see an issue with dropping the SelectField
* fix(core): delete duplicate select component * fix: remove console.log
What/Why?
SelectFieldwas wrapping theSelectcomponent and causing double label/errors to be displayed. DeletesSelectFieldin favor ofSelect.Added the workaround for the Radix issue to the
Selectcomponent. Confirmed issue is not resolved.Testing
Before:

After:

Migration
Remove
SelectFieldand update components to useSelectinstead.