fix(reviews): default button label for review form#2757
Merged
matthewvolk merged 1 commit intocanaryfrom Dec 10, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 91e7ddb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
jorgemoya
approved these changes
Dec 9, 2025
jamesqquick
pushed a commit
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Adds a default value for the
formButtonLabelprop in the reviews section components to prevent missing button labels.Changes:
formButtonLabelto'Write a review'in bothReviewsandReviewsEmptyStateformButtonLabelfromReviewstoReviewsEmptyState(was missing)This ensures the review form button always displays a label, even when
formButtonLabelisn't provided.Testing
Before
After
Migration
If you've customized the
ReviewsorReviewsEmptyStatecomponents incore/vibes/soul/sections/reviews/index.tsx:formButtonLabelexplicitly — your custom label will continue to work.formButtonLabeland want a different default, passformButtonLabelexplicitly with your preferred text.'Write a review'. If you want a different default, override it in your implementation.Note: This pull request description was generated with the assistance of AI.