refactor(reviews): refactor ReviewForm for more flexible rendering#2753
Merged
matthewvolk merged 1 commit intocanaryfrom Dec 9, 2025
Merged
refactor(reviews): refactor ReviewForm for more flexible rendering#2753matthewvolk merged 1 commit intocanaryfrom
matthewvolk merged 1 commit intocanaryfrom
Conversation
🦋 Changeset detectedLatest commit: ee48dfc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
chanceaclark
approved these changes
Dec 9, 2025
jorgemoya
approved these changes
Dec 9, 2025
jamesqquick
pushed a commit
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Refactors
ReviewFormto accept atriggerprop (React.ReactNode) instead offormButtonLabel(string). This allows any React node as the trigger, not just a button with a label.Changes:
formButtonLabelprop fromReviewFormtriggerprop (React.ReactNode)ReviewsandReviewsEmptyState), which create the Button and pass it astriggerImproves flexibility and separation of concerns by letting parents control trigger rendering.
Testing
Migration
Breaking change:
ReviewFormno longer acceptsformButtonLabel. Update usages:Before:
After:
The trigger prop accepts any React node, allowing custom trigger components.
Note: This pull request description was generated with the assistance of AI.