refactor(cli): run build directly on core #2527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
matthewvolk
force-pushed
the
CATALYST-1421-refactor-build
branch
from
86431bd to
cf06cc2
Compare
matthewvolk
force-pushed
the
CATALYST-1421-refactor-build
branch
from
cf06cc2 to
e3b2bc9
Compare
jorgemoya
approved these changes
Aug 19, 2025
matthewvolk
force-pushed
the
CATALYST-1421-refactor-build
branch
from
e3b2bc9 to
6a0939e
Compare
matthewvolk
force-pushed
the
CATALYST-1421-refactor-build
branch
from
6a0939e to
97ace8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Warning
Depends on #2531
Previously,
buildwas running inside of a temporary directory in an effort to abstract away Cloudflare-related configuration files (wrangler.jsonc,open-next.config.ts) and dependencies (@opennextjs/cloudflare). The only artifact that we copied from this temporary directory back into the original Catalyst project was a singleworker.jsfile.Unfortunately, we discovered that the
opennextjs-cloudflare previewcommand needs access to some of the intermediary files that were being deleted when the temporary folder was deleted at the end ofbuild.This PR removes the temporary directory step and runs
opennextjs-cloudflare buildto programmatically build the application incore.Testing
If you'd like to test this PR locally, follow these steps:
packages/cli, runpnpm buildcdintocorenode /path/to/catalyst/packages/cli/dist/index.js link ...node /path/to/catalyst/packages/cli/dist/index.js build --framework catalystMigration
N/A
JIRA: CATALYST-1421