Problem: The send function is deprecated #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: remove the send function
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
==========================================
- Coverage 98.74% 98.72% -0.03%
==========================================
Files 5 5
Lines 239 235 -4
==========================================
- Hits 236 232 -4
Misses 3 3 |
ttmc
reviewed
Sep 17, 2018
| https://docs.bigchaindb.com/projects/py-driver/en/latest/handcraft.html#send-the-transaction | ||
| """ | ||
|
|
||
| warn('The method .send will be deprecated in the next release of the ' |
There was a problem hiding this comment.
Does this mean that all the docs warning messages, like this
will go away, or do you have to remove those manually?
There was a problem hiding this comment.
It is gone. The warning was written in the docstring of the function and since we removed it, the warning is gone too
ttmc
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: remove the send function
Fixes #482