Introduce ApiParameterMapper-Attribute Class - #253
Merged
GhaziTriki merged 9 commits intoMar 29, 2025
Conversation
DigitalTimK
changed the title
GhaziTriki
added
the
enhancement
# Conflicts: # src/BigBlueButton.php # tests/BigBlueButtonTest.php # tests/Parameters/CreateMeetingParametersTest.php
Member
|
@DigitalTimK Thank you very much for this high quality PR. And my apologies for the late review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will:
getHTTPQuery()into a separatetoArray()-functionApiParameterMapper-AttributeClass (new php8 feature), using at the getter of each parameter values to generate the former data array (seetoArray()-function) automatically withtoApiDataArray()-function.getHttpQuery()-function to use newtoApiDataArray()-function instead oftoArray()-functiontoArray()-function as deprecated (shall be removed once new concept is bullet prove)toArray()-function andtoApiDataArray()-function deliver identical contentWhile working on the parameter generation this PR will improve in addition:
MetaParameters-classUserDataParameters-class