Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update from develop #7

Merged
merged 4 commits into from
May 16, 2022
Merged

chore: update from develop #7

merged 4 commits into from
May 16, 2022

Conversation

pedrobmarin
Copy link
Collaborator

No description provided.

Avoid locking API calls that do not contain any parameter such as `createGroup`.

When a meeting is created at BigBlueButton, the Meteor server sends an event requiring
the creation of a pad's group for the `notes` feature. Since `createGroup` does
not contains any parameters it's lock key was built using only the method's signature,
locking any other `createGroup` call within the server.

Included a timestamp for lock's key when the method lacks parameters.
@pedrobmarin pedrobmarin merged commit 3eb45a5 into main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant