Skip to content

Conversation

@johnmunster
Copy link
Contributor

@johnmunster johnmunster commented Oct 4, 2023

Description

This PR Completes the following goals on #4:

  • Update Cypress config to remove Cucumber
  • Remove any Cucumber related files and code
  • Re-write any existing tests to use Cypress without Cucumber

This was achieved by removing the following packages @badeball/cypress-cucumber-preprocessor, @cypress/webpack-preprocessor & gherkin-lint along with any code references, files or scripts associated with these packages and refactoring the tests back to use Cypress syntax.

Change Log

Removed

Packages

  • @badeball/cypress-cucumber-preprocessor
  • @cypress/webpack-preprocessor
  • gherkin-lint

Changed

  • Cypress.config.js
  • Cypress tests filenames
  • Cypress test code

Steps to test

Ran the tests locally to ensure the tests still pass

Screenshots/Videos

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@johnmunster johnmunster requested a review from g-elwell October 4, 2023 10:09
Copy link
Member

@g-elwell g-elwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, cypress tests run and complete as expected
image

@g-elwell g-elwell changed the title Chore: Upgrade wp-cypress, remove cucumber, gherkin linter and refactor tests back to Cypress syntax [4] Upgrade wp-cypress, remove cucumber, gherkin linter and refactor tests back to Cypress syntax Nov 14, 2023
@johnmunster johnmunster marked this pull request as ready for review November 14, 2023 12:22
@johnmunster johnmunster merged commit eb40d37 into main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants