Skip to content

Conversation

jordanharris-6
Copy link
Contributor

@jordanharris-6 jordanharris-6 commented Oct 30, 2024

Description

36 - When adding the plugin to a site the composer file wasn't finding the branch main-built this is because the main-built branch doesn't have a composer.json file. When a repository includes a composer.json file, it defines aspects of itself that are important to how Composer manages the package and if it can't find a composer.json file it just ignores that branch.

Change Log

  • Removed composer.json from the .deployignore file

Steps to test

Add the following to your composer.json file on a project which doesn't have the plugin currently

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/bigbite/image-comparison.git"
        }
	],
    "require": {
    "composer/installers": "^2.0",
    "bigbite/image-comparison": "dev-chore/update-ci-built"
	},
	"extra": {
    "installer-paths": {
      "plugins/{$name}/": [
        "type:wordpress-plugin"
      ]
    }
  },
  "config": {
    "preferred-install": "dist",
    "allow-plugins": {
      "composer/installers": true
    }
  }

then run composer install

Once this is merged main-built will have the composer.json file and the instructions in the readme will work correctly.

Screenshots/Videos

http://bigbite.im/i/XKilri

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@jordanharris-6 jordanharris-6 requested review from a team, chrishbite and jaymcp as code owners October 30, 2024 11:29
@chrishbite chrishbite linked an issue Oct 30, 2024 that may be closed by this pull request
@jaymcp jaymcp merged commit 2f42424 into main Nov 18, 2024
1 check passed
@jaymcp jaymcp deleted the chore/update-ci branch November 18, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Composer install steps not working

2 participants