Skip to content

Enable ext.args support in GENERATE_CFG module#641

Merged
jpfeuffer merged 2 commits into
devfrom
copilot/update-ext-args-nf-core-standard
Jan 14, 2026
Merged

Enable ext.args support in GENERATE_CFG module#641
jpfeuffer merged 2 commits into
devfrom
copilot/update-ext-args-nf-core-standard

Conversation

Copilot AI commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

The GENERATE_CFG module defined task.ext.args but never used it in the command invocation, preventing users from passing additional arguments via nf-core's standard configuration mechanism.

Changes

  • Added $args to the quantmsutilsc dianncfg command invocation in modules/local/diann/generate_cfg/main.nf

Usage

Users can now configure additional arguments through their config files:

process {
    withName: 'GENERATE_CFG' {
        ext.args = '--custom-option value'
    }
}

The change is backward compatible—existing workflows continue to work unchanged.

Original prompt

Allow the ext.args according to nf-core standard in the generate_cfg


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@coderabbitai

coderabbitai Bot commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Co-authored-by: jpfeuffer <8102638+jpfeuffer@users.noreply.github.com>
Copilot AI changed the title [WIP] Allow ext.args according to nf-core standard in generate_cfg Enable ext.args support in GENERATE_CFG module Jan 14, 2026
Copilot AI requested a review from jpfeuffer January 14, 2026 10:05
@jpfeuffer jpfeuffer marked this pull request as ready for review January 14, 2026 10:07
@ypriverol

Copy link
Copy Markdown
Member

@copilot Can you increase the version on dev to 1.8.0dev

@jpfeuffer

Copy link
Copy Markdown
Collaborator

@ypriverol This has to be part of the release process! It needs to be done immediately after release.

@ypriverol

Copy link
Copy Markdown
Member

@jpfeuffer Agree, but this is the first PR after the release; we were working on the increase of the version. I can do a different PR for that.

@jpfeuffer jpfeuffer merged commit 1cee707 into dev Jan 14, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants