Enable ext.args support in GENERATE_CFG module#641
Merged
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: jpfeuffer <8102638+jpfeuffer@users.noreply.github.com>
jpfeuffer
approved these changes
Jan 14, 2026
Copilot
AI
changed the title
[WIP] Allow ext.args according to nf-core standard in generate_cfg
Enable ext.args support in GENERATE_CFG module
Jan 14, 2026
jpfeuffer
approved these changes
Jan 14, 2026
Member
|
@copilot Can you increase the version on dev to 1.8.0dev |
Collaborator
|
@ypriverol This has to be part of the release process! It needs to be done immediately after release. |
Member
|
@jpfeuffer Agree, but this is the first PR after the release; we were working on the increase of the version. I can do a different PR for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GENERATE_CFGmodule definedtask.ext.argsbut never used it in the command invocation, preventing users from passing additional arguments via nf-core's standard configuration mechanism.Changes
$argsto thequantmsutilsc dianncfgcommand invocation inmodules/local/diann/generate_cfg/main.nfUsage
Users can now configure additional arguments through their config files:
process { withName: 'GENERATE_CFG' { ext.args = '--custom-option value' } }The change is backward compatible—existing workflows continue to work unchanged.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.