Description of the bug
After merging #82 (comet+msgf consensus feature union), we should explicitly validate and (if needed) generalize the same logic for SAGE-involving configurations.
Context
PR #82 fixed the two-engine comet,msgf path by:
- unioning per-engine numeric features,
- applying orientation-aware worst-case imputation,
- adding engine-source indicators.
SAGE support was not explicitly covered in the PR scope/results/tests.
Reference: bigbio/quantms-rescoring#82
Goal
Ensure consensus feature construction behaves correctly for SAGE in:
search_engines=sage
search_engines=comet,sage
search_engines=msgf,sage
- (optional)
search_engines=comet,msgf,sage if fully supported
Acceptance criteria
Suggested tests
Add coverage in tests/test_consensus_features.py (or equivalent) for:
- single-engine SAGE,
- comet+sage overlap and single-engine subsets,
- msgf+sage overlap and single-engine subsets,
- optional three-engine merge (
comet,msgf,sage).
Also validate both:
- ms2features-off (
psm_feature_clean) path,
- ms2features-on (annotator) path.
Command used and terminal output
Relevant files
No response
System information
No response
Description of the bug
After merging #82 (comet+msgf consensus feature union), we should explicitly validate and (if needed) generalize the same logic for SAGE-involving configurations.
Context
PR #82 fixed the two-engine
comet,msgfpath by:SAGE support was not explicitly covered in the PR scope/results/tests.
Reference: bigbio/quantms-rescoring#82
Goal
Ensure consensus feature construction behaves correctly for SAGE in:
search_engines=sagesearch_engines=comet,sagesearch_engines=msgf,sagesearch_engines=comet,msgf,sageif fully supportedAcceptance criteria
extra_featurescontains expected SAGE-derived numeric features in SAGE-involving runs.inf/sentinel artifacts leak into model features for SAGE paths.Suggested tests
Add coverage in
tests/test_consensus_features.py(or equivalent) for:comet,msgf,sage).Also validate both:
psm_feature_clean) path,Command used and terminal output
Relevant files
No response
System information
No response