Protein modification Acetyl instead of Acetylation in SDRF readme?

[hollenstein]

Hi, I am currently trying to understand how to use the SDRF format and stumbled upon a very minor issue in the documentation for protein modifications.

The shown example is for Acetylation

• NT=Acetylation
• AC=UNIMOD:1
• CF=H(2)C(2)O

But shouldn't it be "Acetyl", which is listed as the psi-ms name on unimod? At least on unimod "Acetylation" is only the description. As this is the only mandatory term for describing the modification I would assume you want to use the most "official" term possible. Or is this not the case?

Best,
David

[ypriverol]

@hollenstein You are absolutely rigth, even our examples are referencing to Acetyl. Can you do a PR to dev fixing that small issue. I can do it but is better that the format and specification have the contribution of the community 😉.

The new version of the format is under development in dev. Please let me know if you are willing to do the change if not I will do it.

This PR #733 is handling the new version.

[hollenstein]

Sure, I can do that. But I am not sure I understood what you meant with your comment about the development branch, and the PR #733 for merging the dev changes into main.

Should I make a PR for making a change in main or in dev or in both (as this only fixes a minor oversight and does not really change anything)?

[ypriverol]

In dev. Do the PR against dev branch.

Thanks a lot @hollenstein