removing hardcoded -site extension #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we are already passing the path information to the configure() function, there is no need to regenerate the file name using static -site extension. By doing so, This function can be used for configuration files that do not end with site.xml such as capacity-scheduler.xml
|
@gmouchakis can you take a look to this PR when you have time? |
|
Hi @mmigdiso, apologies for the delayed response. You are right, there is no need to hardcore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are already passing the path information to the configure() function, there is no need to regenerate the file name using static -site extension. By doing so, This function can be used for configuration files that do not end with site.xml such as capacity-scheduler.xml