Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added name parameter for output file #6

Closed
wants to merge 1 commit into from

Conversation

gustav-dahl
Copy link
Contributor

I have added an name parameter to be able to specify an name for the output fil.

@biesbjerg
Copy link
Owner

biesbjerg commented Dec 23, 2016

Thank you for the PR!

Rather than introduce another argument I'd prefer if the output arg was smarter (preferably in a backwards compatible way):

  1. No output arg provided: save to ./template.FORMAT (current behavior)

  2. Output arg is provided with value '/dir' and dir exists: save to /dir/template.FORMAT (current behavior)

  3. Output arg is a provided with value 'en.json' (and en.json is not a dir): save to ./en.json

  4. Output arg is provided with value '/dir/file.txt': Save to /dir/file.txt

What do you think?

@biesbjerg
Copy link
Owner

Added in this commit: 031890c

@biesbjerg biesbjerg closed this Dec 23, 2016
@gustav-dahl
Copy link
Contributor Author

gustav-dahl commented Dec 23, 2016

That sounds like a great alternative. Thank you for the fast feed back and an awesome project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants