Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code and add DirectiveParser #2

Merged
merged 6 commits into from
Dec 7, 2016
Merged

Refactor code and add DirectiveParser #2

merged 6 commits into from
Dec 7, 2016

Conversation

biesbjerg
Copy link
Owner

  • Refactor code
  • Add DirectiveParser (Thanks, @ocombe!)

@biesbjerg biesbjerg merged commit a45ca2b into master Dec 7, 2016
@biesbjerg biesbjerg deleted the ocombe-directive-parsing branch December 7, 2016 05:19
@davemeech davemeech mentioned this pull request Jan 5, 2019
Closed
P4 pushed a commit to P4/ngx-translate-extract that referenced this pull request Dec 21, 2022
@bartholomej
Merge pull request biesbjerg#2 from Francesco-Manicardi/patch-1
8c7cba4 
Fix reference to old package in readme
sod pushed a commit to sod/ngx-translate-extract that referenced this pull request Nov 24, 2023
@P4
fix: Find uses of translate pipe in pipe arguments (biesbjerg#2)
8e7a3fe 
* refactor(pipe-parser) simplify handling of pipes in getTranslatablesFromAst

remove expressionIsOrHasBindingPipe - previously this also handled cases like `'World' | translate | upper`,
but it's not actually needed, getTranslatablesFromAst can deal with it by itself

move checks for translate and non-translate pipes together under a common BindingPipe check.

* fix(pipe-parser): find usages of translate pipe in arguments of other pipes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biesbjerg @ocombe