[STY] add some admonitions to common principles #1950
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Remi-Gau
commented
Oct 10, 2024
Remi-Gau
commented
- closes none
- add some admonitions to the common principle page
Remi-Gau
added
the
exclude-from-changelog
effigies
reviewed
Oct 10, 2024
src/common-principles.md
Outdated
Comment on lines
740
to
751
| {{ MACROS___make_filetree_example( | ||
| { | ||
| "sub-01": { | ||
| "func": { | ||
| "sub-01_task-rest_acq-default_bold.nii.gz": "", | ||
| "sub-01_task-rest_acq-longtr_bold.nii.gz": "", | ||
| "sub-01_task-rest_acq-longtr_bold.json": "", | ||
| } | ||
| }, | ||
| "task-rest_bold.json": "", | ||
| } | ||
| ) }} |
There was a problem hiding this comment.
Does the rendering code respect indentations?
There was a problem hiding this comment.
yeah I want to check how the macros and PDF are affected by this.
There was a problem hiding this comment.
keeping as draft for now.
There was a problem hiding this comment.
hum...
not great so far:
I think the macro is affecting this
There was a problem hiding this comment.
There was a problem hiding this comment.
Sweet!!!
Need me update our contributing doc about this.
|
Okay, if we want to do this, we'll need to switch our macro preprocessing for the PDF to use jinja2, so that the same tools are available to us in mkdocs and the pdf builder. Otherwise it's going to be hack upon hack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.