-
Notifications
You must be signed in to change notification settings - Fork 185
[ENH] microelectrode electrophysiology specification (BEP032) #1705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
src/schema/objects/columns.yaml
Outdated
@@ -42,6 +42,38 @@ age: | |||
for privacy purposes. | |||
type: number | |||
unit: year | |||
alpha_rotation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd really recommend renaming the rotation axes to yaw, roll, and pitch (that would be the analogous angle order). There was no consensus either way on the google docs discussion. Someone said both are confusing, which I guess might be expected, but alpha, beta, gamma, are just more confusing...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree -- very adhoc. Let's discuss in google doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you chime in? I think the other guy commenting might be amenable to accepting this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that both are confusing, but at least alpha, beta and gamma are SO confusing that everyone realizes that additional specification is needed to define them properly. With roll, yaw and pitch it seems at first that all is clear, until you have a number of different people go through different use cases. See the more challenging examples that I posted on the google doc under https://docs.google.com/document/d/1oG-C8T-dWPqfVzL2W8HO3elWK8NIh2cOCPssRGv23n0/edit?disco=AAAA4fkI4eY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robertoostenveld sorry, I only now saw the update, reply there. I don't think confusion on purpose is good in this case, because the documentation is very eclectic so we might be sending people down rabbit holes. Wiki, where people will invariably go first, does a particularly poor job explaining both euler and TB angles for the casual non-mathematics-versed user. The only thing that wiki has going for it here are the aircraft animations on the TB page. Yaw, Pitch, Roll, will be intuited correctly as long as we specify the starting postion. That we can do (1) as (I think, it's pretty vague) is currently proposed, aligning the implant with the world coordinate system (meaning most implants will be at yaw 0 pitch -90 roll 0) or (2) relative to the implantation stereotax normal (meaning most implants will be at 0 0 0).
For comparison, Euler commonly has the normal pointing up so most implants will be.... 0 -180 0 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the last BEP032 meeting we discussed further and wanted to follow this approach now (based on the Allen Inst. standard and IBL standard):
Assumption: x,y,z is posterior, ventral, right (unit needs to be specified).
Translational origin (0,0,0) needs to be defined (typically Bregma for rodents).
Rotational origin (0,0,0) is the probe facing up with the tip facing forward. Rotations are all clockwise in degrees and around the tip. For multi-shank probes, the “tip” of the probe is defined as the end of the left shank if you are looking at the electrodes.
- yaw: clockwise when looking down
- pitch: In the direction of the electrode face
- roll: clockwise when looking down at the probe
The depth (unit needs to be specified) is a translation in the direction that the tip is pointing.
We need to add a “probe_model”, which references probeinterface_library
NOTE: We need to change the electrode x,y,z.
X,y,z in BIDS refers to location in brain, not on probe.
Also relevant if you'd like to comment. → https://docs.google.com/document/d/1oG-C8T-dWPqfVzL2W8HO3elWK8NIh2cOCPssRGv23n0/edit?disco=AAABIzHGpUU |
Also I forgot to link to this when I wrote it → https://docs.google.com/document/d/1oG-C8T-dWPqfVzL2W8HO3elWK8NIh2cOCPssRGv23n0/edit?disco=AAABIGPAMOw |
Hello all, I am working diligently on bringing I have scoured this discussion to the best of my ability, so apologies if this has come up before - has it been firmly decided to call the 'physical recording entities' on the probes EDIT: from meeting on 6/18/25, electrodes has been firmly decided |
* fix: schemapath resolution in Windows dev mode installation of bidsschematools * fix: schema validation through testing * chore: resolve conflict
Update on 6/18/25 PR requires further testing on more extreme real datasets (both ecephys and icephys) with particular focus on probes and coordinate metadata (including insertion): It also requires some external changes to be merged first:
We will be ramping up the regular working group meeting to every 2 weeks to try to gain momentum to get this done (hopefully by end of summer) |
…ify channel information
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
[BEP32 fix] Reorder required metadata files for microephys sessions and clarify channel information
[BEP032] [FIX] Validation rules for events
src/modality-specific-files/microelectrode-electrophysiology.md
Outdated
Show resolved
Hide resolved
…ides - Replace x,y,z coordinates with standardized AP/ML/DV system - Add anatomical reference points (Bregma/Lambda) explanations - Include detailed angle measurement conventions with diagrams - Add 6 illustrative images for coordinate system understanding - Update electrode table example to use new coordinate naming
- Add AP__probes column for Anterior-Posterior probe positioning - Add ML__probes column for Medial-Lateral probe positioning - Add missing unit specification (mm) to existing DV__probes column
…s-specification into bep32_rotation
- Add ProbeInterface format links and JSON schema requirements for custom probes - Standardize requirement language (MUST/SHOULD) for coordsystem fields - Remove deprecated ProbeContours section
Add comprehensive stereotaxic coordinate documentation with visual guides
Replaces #1352 submitted from a fork outside of bids-specification.
Add specification for microelectrode electrohpysiology datasets based on the BEP032 proposal. old google doc
Note
We meet regularly and everyone is welcome
Next meeting: insert date on URL to join
Communication channel: https://framalistes.org/sympa/info/neuroscience-data-structure
Tip
HTML preview of this BEP
bids-validator
with a custom schema. (attn @TheChymera)DONEs
TODOs
Please ensure your name is credited on our Contributors appendix.
To add your name, please edit our Contributors wiki and add your name with the type of contribution.
For assistance, please tag @bids-standard/maintainers.
After opening the PR, our continuous integration services will automatically check your contribution for formatting errors and render a preview of the BIDS specification with your changes.
To see the checks and preview, scroll down and click on the
show all checks
link.From the list, select the
Details
link of theci/circleci: build_docs artifact
check to see the preview of the BIDS specification.Add instructions here on how to run new
bids-validator
using schema in this PRc557d1f
to1c30c6e
legacy-validator#1798 is the first one trying it on whitelisted set of packages, and I think we should create a helper action for that : https://github.com/bids-standard/bids-validator/issues/1931bids-validator changes needed
Populate schema with specifications from the google doc ...
schema/rules/checks
with checks specific to this BEP032 (from experiences with data conversion eg by @CodyCBakerPhD on @mvmdmlab data)<extension>
and get a table of extensions (nwb and nix) and check if schema encodes that only one is allowedFurther markdown description: @Peyman-N is working on a PR
Define enums of coord spaces to be added -- some image based, some ad-hoc
Add and reference here PR on
bids-examples
adding sample dandisets : Draft examples for BEP032 on animal electrophysiology bids-examples#430 (@robertoostenveld )Add CI action (likely github) to run
bids-validator
on sample datasets and this modified schema (@yarikoptic)Decide on "contours" specification
type
column for electrodes[ie]cephys/
sectionShare/use examples of real datasets
Issues this PR would likely to address
Issues to see being addressed while working on this BEP (likely to move above) or not (moved below):
Other issues which relate but not in scope here and provided for reference/backreference
Spreadsheet with correspondence to ProbeInterface: https://docs.google.com/spreadsheets/d/1O0bZzD-n4MjR68r1GlcH3d2JLXBLAU1PfsDceD3IPeo/edit?usp=sharing
steps to use bids-validator-deno against this modified schema