Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Consistently reference object keys in rules #1203

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

[REF] Consistently reference object keys in rules #1203

wants to merge 12 commits into from

Commits on Aug 16, 2022

  1. Move test_rules.

    @tsalo
    tsalo committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    e2f0b24 View commit details
    Browse the repository at this point in the history

  2. Replace extension values with extension keys.

    @tsalo
    tsalo committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    b4055e8 View commit details
    Browse the repository at this point in the history

  3. Replace suffix values with suffix keys.

    @tsalo
    tsalo committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    9958fec View commit details
    Browse the repository at this point in the history

  4. Move rules/sidecars/entities.yaml. 

    The problem is that test_rules looks for any dictionaries (including files) that have a key matching an object type, such as "suffixes", "metadata", or "entities". The name "entities" can thus be considered reserved.
    @tsalo
    tsalo committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    b3c55dc View commit details
    Browse the repository at this point in the history

  5. Fix column names in rules. 

    Some were mistyped and didn't match the objects.
    @tsalo
    tsalo committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    6d06174 View commit details
    Browse the repository at this point in the history

  6. Finish replacing extensions.

    @tsalo
    tsalo committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    25a8e2e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into fix-test

    @tsalo
    tsalo authored Aug 16, 2022
    Configuration menu
    Copy the full SHA
    9765900 View commit details
    Browse the repository at this point in the history

  8. Still need to skip derivatives folder.

    @tsalo
    tsalo committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    586bf94 View commit details
    Browse the repository at this point in the history

  9. Skip the derivatives folder.

    @tsalo
    tsalo committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    4288f24 View commit details
    Browse the repository at this point in the history

  10. Keep fixing.

    @tsalo
    tsalo committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    c8c9c0c View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'upstream/master' into fix-test

    @tsalo
    tsalo committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    0b99c32 View commit details
    Browse the repository at this point in the history

  12. Update tools/schemacode/bidsschematools/tests/test_rules.py 

    Co-authored-by: Chris Markiewicz <effigies@gmail.com>
    @tsalo @effigies
    tsalo and effigies authored Aug 16, 2022
    Configuration menu
    Copy the full SHA
    1e03f4a View commit details
    Browse the repository at this point in the history