Skip to content

[ENH] Update tables in readme #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 14, 2021
Merged

[ENH] Update tables in readme #294

merged 7 commits into from
Oct 14, 2021

Conversation

Remi-Gau
Copy link
Contributor

fixes #224

and related to bids-standard/bids-specification#845

  • autolint README
  • extract PET, ASL, qMRI into separate tables
  • update headers
  • remove unnecessary columns
  • update multimodal table with mri datatypes
  • move eeg_cbm to EEG table
  • split MRI table in several columns

@Remi-Gau
Copy link
Contributor Author

The rendered view would look like this: https://github.com/bids-standard/bids-examples/blob/e508002e09b100acb55a23911debed7357f6a9f8/README.md

sappelhoff
sappelhoff reviewed Oct 13, 2021
View reviewed changes
sappelhoff
sappelhoff approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Remi-Gau

@sappelhoff sappelhoff merged commit 9da1390 into bids-standard:master Oct 14, 2021
@Remi-Gau Remi-Gau deleted the update_README branch November 9, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnoergaard mnoergaard mnoergaard left review comments

@sappelhoff sappelhoff sappelhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve columns in README: modality, datatype -> comma separated lists
3 participants
@Remi-Gau @sappelhoff @mnoergaard