Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GitHub action #159

Merged
merged 5 commits into from
Jan 26, 2023
Merged

Improve GitHub action #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
97a2060
add ruby 3.1 and 3.2
LeipeLeon Jan 25, 2023
6458151
default to 3.2 when no RUBY_IMAGE is given
LeipeLeon Jan 25, 2023
58f664d
enh: Setup Ruby w/ same version as image
LeipeLeon Jan 25, 2023
4576b4f
improve comments
LeipeLeon Jan 25, 2023
f8f379e
eat our own dogfood and use the dip command from the repo
LeipeLeon Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,20 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [ '2.5', '2.6', '2.7', '3.0' ]
ruby: [ '2.5', '2.6', '2.7', '3.0', '3.1', '3.2' ]
env:
RUBY_IMAGE: ${{ matrix.ruby }}
RUBY_IMAGE: ${{ matrix.ruby }} # The image used in the Dockerfile
name: Ruby ${{ matrix.ruby }}
steps:
- uses: actions/checkout@v2
- name: Set up Ruby
- name: Checkout code
uses: actions/checkout@v3
- name: Setup Ruby w/ same version as image
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.7
ruby-version: ${{ matrix.ruby }}
- name: Install dependencies
run: |
gem install dip
rake install
dip provision
- name: Run linters
run: dip rubocop
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:
app:
image: ruby:${RUBY_IMAGE:-3.0}-buster
image: ruby:${RUBY_IMAGE:-3.2}-buster
environment:
- GEM_HOME=/bundle
- BUNDLE_PATH=/bundle
Expand Down