Skip to content

Fix error on rollback #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bibendi merged 2 commits into from
May 28, 2024
Merged

Fix error on rollback #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dafd5d1
handle rollback when options are included on enum creation
BClark88 May 28, 2024
6f572cd
handle when no options included, additional spec
BClark88 May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/active_record/postgres_enum/command_recorder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
module ActiveRecord
module PostgresEnum
module CommandRecorder
def create_enum(name, values)
def create_enum(name, values, _opts = nil)
record(:create_enum, [name, values])
end

Expand Down
14 changes: 13 additions & 1 deletion spec/active_record/migrations_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
RSpec.describe ActiveRecord::PostgresEnum::CommandRecorder do
let(:connection) { ActiveRecord::Base.connection }

it "reverts create_enum" do
it "reverts create_enum with no options" do
migration = build_migration { create_enum :genre, %w[drama comedy] }

migration.migrate(:up)
Expand All @@ -17,6 +17,18 @@
expect(connection.enum_types[:genre]).to be_nil
end

it "reverts create_enum with options" do
migration = build_migration { create_enum :genre, %w[drama comedy], force: true, if_not_exists: true }

migration.migrate(:up)

expect(connection.enum_types[:genre]).to eq %w[drama comedy]

migration.migrate(:down)

expect(connection.enum_types[:genre]).to be_nil
end

it "reverts rename_enum" do
build_migration { create_enum :genre, %w[drama comedy] }.migrate(:up)

Expand Down