Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Nonlinear dimensionality specification #187

Merged
merged 5 commits into from
Dec 15, 2021
Merged

Refactor Nonlinear dimensionality specification #187

merged 5 commits into from
Dec 15, 2021

Conversation

ThijsvdLaar
Copy link
Collaborator

@ThijsvdLaar ThijsvdLaar commented Dec 6, 2021

  • Refactor dimensionality specification as Tuple
  • Refactor nonlinear update specifications
  • Remove need for manually specifying variate types for Nonlinear{Sampling}
  • Additional rules for Nonlinear{Sampling}

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2021

Codecov Report

Merging #187 (1629798) into master (b10b720) will increase coverage by 0.39%.
The diff coverage is 88.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   86.21%   86.60%   +0.39%     
==========================================
  Files          95       95              
  Lines        4462     4406      -56     
==========================================
- Hits         3847     3816      -31     
+ Misses        615      590      -25     
Impacted Files Coverage Δ
src/engines/julia/update_rules/multiplication.jl 100.00% <ø> (ø)
src/factor_nodes/wishart.jl 94.23% <ø> (+1.63%) ⬆️
...c/engines/julia/update_rules/nonlinear_sampling.jl 63.04% <57.57%> (+4.44%) ⬆️
src/factor_nodes/sample_list.jl 76.21% <68.75%> (+2.65%) ⬆️
src/factor_nodes/gaussian_mean_variance.jl 88.67% <71.42%> (-0.21%) ⬇️
src/probability_distribution.jl 78.66% <78.57%> (-1.94%) ⬇️
src/engines/julia/generators.jl 97.67% <100.00%> (ø)
...ines/julia/update_rules/gaussian_mean_precision.jl 100.00% <100.00%> (ø)
src/engines/julia/update_rules/gaussian_mixture.jl 100.00% <100.00%> (ø)
...c/engines/julia/update_rules/nonlinear_extended.jl 100.00% <100.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10b720...1629798. Read the comment docs.

@ThijsvdLaar ThijsvdLaar marked this pull request as ready for review December 6, 2021 13:18
Copy link
Collaborator

@albertpod albertpod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Can be merged.

@ThijsvdLaar ThijsvdLaar merged commit fc11951 into master Dec 15, 2021
@ThijsvdLaar ThijsvdLaar deleted the nlpm branch December 15, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants