Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraints #178

Merged
merged 55 commits into from
Sep 22, 2021
Merged

Constraints #178

merged 55 commits into from
Sep 22, 2021

Conversation

ThijsvdLaar
Copy link
Collaborator

This PR implements the point-mass, chance and moment constraints as proposed in (van de Laar et al. "Chance-Constrained Message Passing", MIT Neural Computation, 2021) and (Senoz et al. "Variational Message Passing and Constraint Manipulation on Factor Graphs", Entropy, 2021).

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2021

Codecov Report

Merging #178 (38f8ef3) into master (5d9110e) will increase coverage by 0.21%.
The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   85.32%   85.53%   +0.21%     
==========================================
  Files          83       92       +9     
  Lines        3877     4259     +382     
==========================================
+ Hits         3308     3643     +335     
- Misses        569      616      +47     
Impacted Files Coverage Δ
src/ForneyLab.jl 100.00% <ø> (ø)
src/engines/julia/update_rules/probit.jl 77.08% <0.00%> (-15.42%) ⬇️
src/factor_nodes/categorical.jl 75.47% <0.00%> (-4.13%) ⬇️
src/factor_nodes/sample_list.jl 73.56% <ø> (-0.85%) ⬇️
src/visualization.jl 0.00% <0.00%> (ø)
src/factor_nodes/bernoulli.jl 82.35% <25.00%> (-7.97%) ⬇️
src/engines/julia/generators.jl 96.51% <50.00%> (-1.62%) ⬇️
...c/engines/julia/update_rules/nonlinear_sampling.jl 58.59% <50.00%> (+0.70%) ⬆️
src/update_rules/nonlinear_sampling.jl 96.05% <57.14%> (-3.95%) ⬇️
src/algorithms/posterior_factor.jl 93.54% <60.00%> (+0.86%) ⬆️
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d9110e...38f8ef3. Read the comment docs.

Copy link
Collaborator

@albertpod albertpod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great contribution to ForneyLab.jl
I will merge this PR.

@albertpod albertpod merged commit d2841fb into master Sep 22, 2021
@ThijsvdLaar ThijsvdLaar deleted the constraints branch September 22, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants