Draft of #54: Configurable extensions#55
Merged
bhurlow merged 3 commits intobhurlow:masterfrom Aug 28, 2018
RhysU:master
Merged
Draft of #54: Configurable extensions#55bhurlow merged 3 commits intobhurlow:masterfrom RhysU:master
bhurlow merged 3 commits intobhurlow:masterfrom
RhysU:master
Conversation
RhysU
commented
Aug 27, 2018
| if !exists('g:vim_parinfer_' . s:key) | ||
| let g:vim_parinfer_{s:key} = copy(g:_VIM_PARINFER_DEFAULTS[s:key]) | ||
| endif | ||
| endfor |
Contributor
Author
There was a problem hiding this comment.
Pattern lifted from syntastic.
RhysU
commented
Aug 27, 2018
| execute "autocmd FileType " . join(g:vim_parinfer_filetypes, ",") . " nnoremap <buffer> <Tab> :call parinfer#do_indent()<cr>" | ||
| execute "autocmd FileType " . join(g:vim_parinfer_filetypes, ",") . " nnoremap <buffer> <S-Tab> :call parinfer#do_undent()<cr>" | ||
| execute "autocmd FileType " . join(g:vim_parinfer_filetypes, ",") . " vnoremap <buffer> <Tab> :call parinfer#do_indent()<cr>" | ||
| execute "autocmd FileType " . join(g:vim_parinfer_filetypes, ",") . " vnoremap <buffer> <S-Tab> :call parinfer#do_undent()<cr>" |
Contributor
Author
There was a problem hiding this comment.
There may well be better/cleaner ways to avoid the repeated joins.
Contributor
Author
There was a problem hiding this comment.
Turns out there is a good pattern, just a let s:foo = expr statement. Still, leaving as-is for now.
Owner
|
@RhysU yea this looks 💯, I'm fine with some repetitions in the joins there since it's very concrete. LMK if this is ready to merge and I will do so |
Contributor
Author
|
@bhurlow, I fixed a couple of typos in the documentation-- please merge away whenever you're hapy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review/test carefully-- I'm new to parinfer, lisp-like languages, and VimScript.