Skip to content

Several code smells, improvements, and clean-up #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2023
Merged

Several code smells, improvements, and clean-up #3

merged 1 commit into from
Mar 19, 2023

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Mar 18, 2023

Hello !

I like that "simple" project :)

If you are intesrested in, I fixed a bunch of code smells (mostly reported by Sourcery), sorted imports, made some clean-up, etc. 🎁

I've a question: are you warking on the project? I saw a context menu not yet implemented, custom node creation not yet working, can't change names of nodes, etc. I'm just curious :)

@bhowiebkr
Copy link
Owner

bhowiebkr commented Mar 19, 2023

Cool yeah I'll check it out. I've been jumping between 2 projects at the moment and I wanted to add some more features to this one. Deleting nodes, save and load the graph, some functionality to a node to recieved the inputs, run code, and signal to the output connections.

I think It'd be nice to have the node classes be saved in their own python files, and than have a separate python file that represents the description of the node graph.

@bhowiebkr bhowiebkr merged commit 879756c into bhowiebkr:master Mar 19, 2023
@BoboTiG BoboTiG deleted the impr-code-smells branch March 19, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants