[ingress-envoy] Set up and enable TLS #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhongy
commented
Dec 25, 2021
| @@ -3,6 +3,9 @@ | |||
| "dockerComposeFile": "docker-compose.yml", | |||
| "service": "app", | |||
| "workspaceFolder": "/kimidori/${localWorkspaceFolderBasename}", | |||
| "settings": { | |||
| "remote.autoForwardPorts": false | |||
There was a problem hiding this comment.
app is behind ingress now, so it should not forward port to host
bhongy
commented
Dec 25, 2021
| @@ -5,7 +5,7 @@ | |||
| "author": "Thanik Bhongbhibhat <email@thanik.me>", | |||
| "license": "MIT", | |||
| "scripts": { | |||
| "start": "parcel serve './src/index.html' --port 8000 --lazy", | |||
| "start": "parcel serve './src/index.html' --port 8000 --lazy --https", | |||
There was a problem hiding this comment.
https mainly because I want parcel to serve hot reload via wss instead of ws so ingress-envoy proxies the upgrade request properly
bhongy
commented
Dec 25, 2021
| return ( | ||
| <iframe | ||
| allow="clipboard-write" | ||
| className="Main" | ||
| frameBorder="0" | ||
| sandbox="" | ||
| sandbox="allow-scripts" |
There was a problem hiding this comment.
Need this so the documents from the proxied services can execute javascript (render React)
bhongy
commented
Dec 25, 2021
| @@ -5,7 +5,7 @@ | |||
| "author": "Thanik Bhongbhibhat <email@thanik.me>", | |||
| "license": "MIT", | |||
| "scripts": { | |||
| "start": "parcel serve './src/index.html' --port 8000 --lazy" | |||
| "start": "parcel serve './src/index.html' --public-url \"/service/profile\" --port 8000 --lazy" | |||
There was a problem hiding this comment.
Hack by hardcoding the proxied path for now. Profile shouldn't know this but I have to figure out static path routing in HTML in reverse proxy setup better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.