Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removed version declaration & renamed compose files. #8

Merged
merged 1 commit into from
Oct 31, 2022
Merged

fix: Removed version declaration & renamed compose files. #8

merged 1 commit into from
Oct 31, 2022

Conversation

kishan-aghera
Copy link
Contributor

@kishan-aghera kishan-aghera commented Oct 30, 2022 •
edited
Loading

What

The PR tries to resolve #7.

  • Removed version declaration (along with comment) from docker-compose.yml
  • Renamed docker-compose.yml to compose.yml

Why

As Compose v2 now supports compose command; We shall adopt and migrate to the new syntax for compose files.

@bhavik2936
Copy link
Owner

Thanks Kishan! For the contribution, nice work.

@bhavik2936 bhavik2936 merged commit fc50ca2 into bhavik2936:main Oct 31, 2022
@kishan-aghera kishan-aghera deleted the fix_issue_7 branch October 31, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REQUEST] Migrate docker-compose.yml for Compose V2
2 participants
@kishan-aghera @bhavik2936