Addressing review comment

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
bharath-techie · Jul 22, 2022 · f4db20b · f4db20b
1 parent 717cd66
commit f4db20b
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/server/src/main/java/org/opensearch/action/search/CreatePitController.java b/server/src/main/java/org/opensearch/action/search/CreatePitController.java
@@ -274,13 +274,14 @@ public void onResponse(DeletePitResponse response) {
                     .filter(r -> !r.isSuccessful())
                     .forEach(r -> failedPitsStringBuilder.append(r.getPitId()).append(","));
                 logger.warn(() -> new ParameterizedMessage("Failed to delete PIT IDs {}", failedPitsStringBuilder.toString()));
-                if (!logger.isDebugEnabled()) return;
-                final StringBuilder successfulPitsStringBuilder = new StringBuilder();
-                response.getDeletePitResults()
-                    .stream()
-                    .filter(r -> r.isSuccessful())
-                    .forEach(r -> successfulPitsStringBuilder.append(r.getPitId()).append(","));
-                logger.debug(() -> new ParameterizedMessage("Deleted PIT with IDs {}", successfulPitsStringBuilder.toString()));
+                if (logger.isDebugEnabled()) {
+                    final StringBuilder successfulPitsStringBuilder = new StringBuilder();
+                    response.getDeletePitResults()
+                        .stream()
+                        .filter(r -> r.isSuccessful())
+                        .forEach(r -> successfulPitsStringBuilder.append(r.getPitId()).append(","));
+                    logger.debug(() -> new ParameterizedMessage("Deleted PIT with IDs {}", successfulPitsStringBuilder.toString()));
+                }
             }
 
             @Override