Skip to content

Commit

Permalink
Fix joaotavora/eglot#865: Don't strip invisible text when formatting …
Browse files Browse the repository at this point in the history
…hover string

This was introduced in joaotavora/eglot#482 due to a bad interaction with a specific
server.  But this solution makes hyperlinks in Eldoc buffers
unclickable, because the markdown-mode function that visits a link
relies on the invisible text.

Per joaotavora/eglot#866 

* eglot.el (eglot--format-markup): Use buffer-string instead of 
filter-buffer-substring
  • Loading branch information
astoff committed Mar 10, 2022
1 parent 791c538 commit ea29817
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lisp/progmodes/eglot.el
Original file line number Diff line number Diff line change
Expand Up @@ -1436,7 +1436,7 @@ Doubles as an indicator of snippet support."
(message-log-max nil))
(ignore-errors (delay-mode-hooks (funcall mode))))
(font-lock-ensure)
(string-trim (filter-buffer-substring (point-min) (point-max))))))
(string-trim (buffer-string)))))

(define-obsolete-variable-alias 'eglot-ignored-server-capabilites
'eglot-ignored-server-capabilities "1.8")
Expand Down

0 comments on commit ea29817

Please sign in to comment.