Added clean columns function #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems needed. |
|
The issue here is that this code is specific to 3 functions, I tested it seems to not break anything, but as we don't have any automated testing other cases might break. |
MarkVaughn
added a commit
that referenced
this pull request
Dec 5, 2013
Added clean columns function
|
If i can find time i'll see if i can add all functions to it. |
|
It's probably the job for a regular expression of sorts, to recognize functions, especially as there are user defined functions and also the fact that this technically should work on other databases than mysql |
|
100% right. i just sent a new pull request. It is using regex now to grab the column name or alias |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.