This repository has been archived by the owner on Oct 9, 2019. It is now read-only.
Fixed Network Type issue #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VMNetwork objects being passed as "Option" type rather than "Network" Type. Matching on the name instead
bgelens
reviewed
May 23, 2017
WapTenantPublicAPI.psm1
Outdated
| } elseif ($P.DefaultValue) { | ||
| } elseif ($P.Name -eq 'VMRoleNetworkRef') { | ||
| Add-Member -InputObject $Output -MemberType NoteProperty -Name $P.Name -Value $($VMNetwork.Name) -Force | ||
| }elseif ($P.DefaultValue) { |
There was a problem hiding this comment.
Could you re-add the space } elseif ($P.DefaultValue)
|
Thanks for this update! Could you address my comment so I can merge it in one go :) Thanks |
|
Oops - typo fixed |
|
Thanks! I'll merge and publish a new version to the gallery this week |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VMNetwork objects are being passed as "Option" type rather than "Network" Type.
Therefore the matching failed and the default network was always being used.
Matching on the name instead - which fixes the workflow.
Unsure if this is an implementation specific issue or not.