Added TestWithExecutor contract to GovHelpers #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Foundry report forge 0.2.0 (23c41b1 2023-01-19T00:08:45.857013991Z)Build loginstalling solc version "0.8.17"
Successfully installed solc 0.8.17
Compiling 46 files with 0.8.17
Solc 0.8.17 finished in 7.97s
Compiler run successful (with warnings)
warning[2018]: Warning: Function state mutability can be restricted to view
--> src/ProxyHelpers.sol:7:3:
|
7 | function getInitializableAdminUpgradeabilityProxyAdmin(Vm vm, address proxy)
| ^ (Relevant source part starts here and spans across multiple lines).
warning[2018]: Warning: Function state mutability can be restricted to view
--> src/ProxyHelpers.sol:19:3:
|
19 | function getInitializableAdminUpgradeabilityProxyImplementation(Vm vm, address proxy)
| ^ (Relevant source part starts here and spans across multiple lines).
| Contract | Size (kB) | Margin (kB) |
|--------------------------|-----------|-------------|
| AaveGovernanceV2 | 0.236 | 24.34 |
| AaveV3Polygon | 0.086 | 24.49 |
| AaveV3PolygonMockListing | 1.976 | 22.6 |
| Address | 0.086 | 24.49 |
| BridgeExecutorHelpers | 0.086 | 24.49 |
| ConfiguratorInputTypes | 0.086 | 24.49 |
| DataTypes | 0.086 | 24.49 |
| GenericV3ListingEngine | 10.088 | 14.488 |
| GovHelpers | 0.236 | 24.34 |
| MockExecutor | 0.437 | 24.139 |
| ProxyHelpers | 0.086 | 24.49 |
| console | 0.086 | 24.49 |
| console2 | 0.086 | 24.49 |
| stdError | 0.591 | 23.985 |
| stdJson | 0.086 | 24.49 |
| stdMath | 0.086 | 24.49 |
| stdStorage | 0.086 | 24.49 |
| stdStorageSafe | 0.086 | 24.49 |Test error
|
❌
sakulstra
reviewed
Jan 19, 2023
src/GovHelpers.sol
Outdated
| abstract contract TestWithExecutor is Test { | ||
| MockExecutor internal _executor; | ||
|
|
||
| function _setUp(address executor) internal { |
There was a problem hiding this comment.
_setUp seems a little to generic for being in the library - i fear this will create name clashes.
Perhaps better _deployMockExecutor or sth along these lines
There was a problem hiding this comment.
_selectPayloadExecutor()? To follow "select" wording of foundry
Co-authored-by: Lukas <lukasstrassel@googlemail.com>
sakulstra
added a commit
that referenced
this pull request
Jan 19, 2023
empty commit to account for #29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is pretty common use case across other projects to have some payload execution infra for tests, so seems appropriate to add it here