PolEthBridge: Update bridge owner and README as well as add missing natspec #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think, now that its being updated. It would be better to move events, natspec, and so on to the interface, and then use @inheritdocs. |
|
@sendra updated! |
sendra
reviewed
Nov 8, 2023
|
address public constant ROOT_CHAIN_MANAGER missing natspec on interface (as this code was not change, could not leave comment directly on code) |
|
@sendra updated, thank you. i added a new function and update the README accordingly to add a convenience function to check whether a token is mapped prior to burning. |
Zer0dot
approved these changes
Nov 10, 2023
|
@Zer0dot alright, i've added the relevant TXs and now it forward ETH as well (when withdrawing WETH) |
sendra
approved these changes
Nov 21, 2023
added 2 commits
November 21, 2023 09:01
Zer0dot
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Update deployment script with correct owner.
Add missing natspec of Bridge contract.
Update README with information on how to process multiple burns in a single transaction.