fix(installer): respect BIN_DIR for PATH and tmux scripts #42
+45
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When users set a custom
CODEX_BIN_DIR, the installer and tmux integration previously still hardcoded~/.local/binin a few places. This made the installed helper scripts and PATH configuration inconsistent with the configured bin directory.This PR removes the remaining
~/.local/bincoupling and makes tmux integration fully honorCODEX_BIN_DIRend-to-end.What changed
BIN_DIR(derived fromCODEX_BIN_DIR) instead of~/.local/bin.BIN_DIR.~/.local/bin; it uses an install-time placeholder replacement so key bindings point to the correctBIN_DIR.ccb-tmux-on.shno longer assumes helper scripts live in~/.local/bin; it resolves helper paths relative to its own location.Why
Customizing
CODEX_BIN_DIRshould be a supported workflow (e.g., shared tool directories, non-default HOME layouts, container/WSL setups). Hardcoding~/.local/binbreaks that expectation and causes “installed but not found” behavior in tmux keybindings / status helpers.Backward compatibility
CODEX_BIN_DIR(i.e.,~/.local/bin).Testing
bash -n install.shandbash -n ccb-tmux-on.sh config/ccb-tmux-off.sh.BIN_DIR.How to verify (manual)
CODEX_BIN_DIR=/your/custom/bin CODEX_INSTALL_PREFIX=/your/prefix install.sh install/your/custom/bin(e.g.,ccb-tmux-on.sh,ccb-border.sh,ccb-status.sh).tmux source-file ~/.tmux.conf~/.local/binremain in the active workflow.Notes
Windows installer paths were reviewed; no analogous
~/.local/binassumption exists there, so no changes were required.