Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include pch header automatically and on-demand #19

Merged
merged 5 commits into from
May 3, 2021

Conversation

Kojoley
Copy link
Contributor

@Kojoley Kojoley commented Apr 23, 2021

Previously it was needed to include pch header in every source file, but Clang does it automatically making the usage non-uniform. It is also a very noisy process to add pch header to an existing project. Automatic on-demand header inclusion solves both issues.

Kojoley added 5 commits April 24, 2021 03:10
Previously it was needed to include pch header in every source file, but Clang does it automatically making the usage non-uniform. It is also a very noisy process to add pch header to an existing project. Automatic on-demand header inclusion solves both issues.
@Kojoley Kojoley force-pushed the feature/automatic-pch-inclusion branch from df10aae to a951957 Compare April 24, 2021 00:13
@Kojoley
Copy link
Contributor Author

Kojoley commented Apr 24, 2021

The CI failure seems to be intermittent, and I am pretty sure they are not caused by the PR. Could be a bug in B2, try adding ASAN/UBSAN to FreeBSD builds.

@grafikrobot
Copy link
Member

The CI failure seems to be intermittent, and I am pretty sure they are not caused by the PR. Could be a bug in B2, try adding ASAN/UBSAN to FreeBSD builds.

There is definitely an asan and memory leak problem hiding. I've run it with asan before locally. But haven't deciphered the issue. Other than it has to do with the response file engine changes I did.

@Kojoley
Copy link
Contributor Author

Kojoley commented Apr 24, 2021

The CI failure seems to be intermittent, and I am pretty sure they are not caused by the PR. Could be a bug in B2, try adding ASAN/UBSAN to FreeBSD builds.

There is definitely an asan and memory leak problem hiding. I've run it with asan before locally. But haven't deciphered the issue. Other than it has to do with the response file engine changes I did.

Memory leaks are bad, but they cannot be a reason for the test fails. I tried to understand what the test is about, but it tests undocumented -p parameter. I guess, for some reason, on FreeBSD workers echo "stderr" 1>&2 sometimes redirects data into a blackhole (the stderr message does not appear neither on stderr nor on stdout), or B2 sometimes do not pump all the stderr data

$(prefix)stderr$(suffix) 1>&2

@grafikrobot grafikrobot merged commit 64dbb27 into bfgroup:main May 3, 2021
@Kojoley Kojoley deleted the feature/automatic-pch-inclusion branch May 3, 2021 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants