Skip to content

silence compiler warnings on -Wsign-conversion #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CharaVerKys wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

silence compiler warnings on -Wsign-conversion #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions include/lyra/parser.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,17 +222,17 @@ class parser
if (style.options_print_order
!= option_style::opt_print_order::per_declaration)
{
std::vector<std::size_t> order_index(std::distance(b, e));
std::vector<std::size_t> order_index( static_cast<std::size_t>(std::distance(b, e)) );
std::iota(order_index.begin(), order_index.end(), 0);
std::stable_sort(order_index.begin(), order_index.end(),
[&](std::size_t i, std::size_t j) {
const parser & pa = **(b + i);
const parser & pb = **(b + j);
const parser & pa = **(b + static_cast<std::ptrdiff_t>(i));
const parser & pb = **(b + static_cast<std::ptrdiff_t>(j));
return style.opt_print_order_less(
pa.get_print_order_key(style),
pb.get_print_order_key(style));
});
for (auto i : order_index) f(style, **(b + i));
for (auto i : order_index) f(style, **(b + static_cast<std::ptrdiff_t>(i)));
}
else
{
Expand Down
6 changes: 3 additions & 3 deletions include/lyra/printer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class ostream_printer : public printer
const option_style & style, const std::string & txt) override
{
const std::string indent_str(
get_indent_level() * style.indent_size, ' ');
static_cast<unsigned int>(get_indent_level()) * style.indent_size, ' ');
os << indent_str << txt << "\n\n";
return *this;
}
Expand All @@ -129,9 +129,9 @@ class ostream_printer : public printer
const std::string & description) override
{
const std::string indent_str(
get_indent_level() * style.indent_size, ' ');
static_cast<unsigned int>(get_indent_level()) * style.indent_size, ' ');
const std::string opt_pad(
26 - get_indent_level() * style.indent_size - 1, ' ');
26 - static_cast<unsigned int>(get_indent_level()) * style.indent_size - 1, ' ');
if (opt.size() > opt_pad.size())
os << indent_str << opt << "\n"
<< indent_str << opt_pad << " " << description << "\n";
Expand Down