Skip to content

Commit

Permalink
Don’t switch to right-handed mode on mobile
Browse files Browse the repository at this point in the history
Continue to use left-to-right layout on mobile rather than switching the
order of the buttons. We still need to use the symmetrical layouts for
the large/screen player styles so I don’t think we should add a player
setting for this unless someone requests it to avoid ambiguity.

https://linear.app/beyondwords/issue/S-5283/make-the-playback-icon-default-to-the-left
  • Loading branch information
tuzz committed Jun 3, 2024
1 parent 16b717c commit 6573c1c
Show file tree
Hide file tree
Showing 576 changed files with 16 additions and 14 deletions.
4 changes: 4 additions & 0 deletions src/components/UserInterface.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,10 @@
height: 144px;
}
.large.mobile.advert_ .controls {
flex-direction: row-reverse;
}
.large .no-image .summary {
grid-column: 1 / span 2;
}
Expand Down
20 changes: 9 additions & 11 deletions src/components/time_indicators/TimeIndicator.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,7 @@
margin-left: -8px;
}
.standard.advert_ {
justify-content: flex-end;
}
.standard.advert_,
.standard.fixed-left.advert_ {
justify-content: flex-start;
}
Expand All @@ -89,27 +86,28 @@
top: 28px;
}
.small.stopped.mobile .inner,
.standard.stopped.mobile .inner {
.small.stopped.mobile .inner {
position: absolute;
left: 40px;
top: 28px;
}
.standard.stopped.fixed-right .inner {
.standard.stopped.mobile .inner {
position: absolute;
left: 36px;
left: 52px;
top: 28px;
}
.standard.stopped.fixed-left .inner {
.standard.stopped.fixed-right .inner {
position: absolute;
left: 52px;
top: 28px;
}
.standard.stopped.mobile.no-logo .inner {
left: 24px;
.standard.stopped.fixed-left .inner {
position: absolute;
left: 52px;
top: 28px;
}
.large .inner {
Expand Down
6 changes: 3 additions & 3 deletions src/helpers/controlsOrder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ const controlsOrder = ({ playerStyle, position, isMobile, isAdvert }) => (
playerStyle === "screen" ? "symmetrical"
: playerStyle === "large" && isMobile ? "symmetrical"
: playerStyle === "standard" && position === "left" ? "left-to-right"
: playerStyle === "standard" && isMobile ? "right-to-left"
: playerStyle === "standard" && isMobile ? "left-to-right"
: playerStyle === "standard" && position === "right" && isAdvert ? "right-to-left"
: playerStyle === "standard" && position === "right" ? "left-to-right-but-swap-ends"
: playerStyle === "small" && position === "left" ? "left-to-right"
: playerStyle === "small" && position === "right" ? "right-to-left"
: playerStyle === "video" && position === "left" ? "left-to-right"
: playerStyle === "video" && isMobile ? "right-to-left"
: playerStyle === "video" && position === "right" ? "right-to-left"
: playerStyle === "video" && isMobile ? "left-to-right"
: playerStyle === "video" && position === "right" ? "left-to-right"
: "left-to-right"
);

Expand Down
Binary file modified test/screenshots/standard-paused-advert-mobile-android.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/screenshots/standard-paused-download-mobile-android.png
Binary file modified test/screenshots/standard-paused-mobile-android.png
Binary file modified test/screenshots/standard-paused-no-logo-mobile-android.png
Binary file modified test/screenshots/standard-paused-playlist-mobile-android.png
Binary file modified test/screenshots/standard-paused-widget-auto-0-desktop-chrome.png
Binary file modified test/screenshots/standard-paused-widget-auto-0-mobile-android.png
Binary file modified test/screenshots/standard-paused-widget-auto-0-mobile-ios.png
Binary file modified test/screenshots/standard-paused-widget-auto-50-mobile-android.png
Binary file modified test/screenshots/standard-paused-widget-auto-50-mobile-ios.png
Binary file modified test/screenshots/standard-paused-widget-center-0-desktop-chrome.png
Binary file modified test/screenshots/standard-paused-widget-center-0-mobile-android.png
Binary file modified test/screenshots/standard-paused-widget-center-0-mobile-ios.png
Binary file modified test/screenshots/standard-paused-widget-center-50-mobile-ios.png
Binary file modified test/screenshots/standard-paused-widget-right-0-desktop-chrome.png
Binary file modified test/screenshots/standard-paused-widget-right-0-mobile-android.png
Binary file modified test/screenshots/standard-paused-widget-right-0-mobile-ios.png
Binary file modified test/screenshots/standard-paused-widget-right-50-mobile-android.png
Binary file modified test/screenshots/standard-paused-widget-right-50-mobile-ios.png
Binary file modified test/screenshots/standard-paused-widget-right-auto-mobile-ios.png
Binary file modified test/screenshots/standard-playing-advert-mobile-android.png
Binary file modified test/screenshots/standard-playing-download-mobile-android.png
Binary file modified test/screenshots/standard-playing-mobile-android.png
Binary file modified test/screenshots/standard-playing-no-logo-mobile-android.png
Binary file modified test/screenshots/standard-playing-playlist-mobile-android.png
Binary file modified test/screenshots/standard-playing-widget-auto-0-desktop-chrome.png
Binary file modified test/screenshots/standard-playing-widget-auto-0-mobile-android.png
Binary file modified test/screenshots/standard-playing-widget-auto-0-mobile-ios.png
Binary file modified test/screenshots/standard-playing-widget-auto-50-mobile-android.png
Binary file modified test/screenshots/standard-playing-widget-auto-50-mobile-ios.png
Binary file modified test/screenshots/standard-playing-widget-center-0-mobile-ios.png
Binary file modified test/screenshots/standard-playing-widget-center-50-mobile-ios.png
Binary file modified test/screenshots/standard-playing-widget-right-0-desktop-chrome.png
Binary file modified test/screenshots/standard-playing-widget-right-0-mobile-android.png
Binary file modified test/screenshots/standard-playing-widget-right-0-mobile-ios.png
Binary file modified test/screenshots/standard-playing-widget-right-50-mobile-ios.png
Binary file modified test/screenshots/standard-playing-widget-right-auto-mobile-ios.png
Binary file modified test/screenshots/standard-stopped-mobile-android.png
Binary file modified test/screenshots/standard-stopped-no-logo-mobile-android.png
Binary file modified test/screenshots/standard-stopped-playlist-mobile-android.png
Binary file modified test/screenshots/standard-stopped-widget-auto-0-desktop-chrome.png
Binary file modified test/screenshots/standard-stopped-widget-auto-0-mobile-android.png
Binary file modified test/screenshots/standard-stopped-widget-auto-0-mobile-ios.png
Binary file modified test/screenshots/standard-stopped-widget-auto-50-mobile-android.png
Binary file modified test/screenshots/standard-stopped-widget-auto-50-mobile-ios.png
Binary file modified test/screenshots/standard-stopped-widget-center-0-mobile-ios.png
Binary file modified test/screenshots/standard-stopped-widget-center-50-mobile-ios.png
Binary file modified test/screenshots/standard-stopped-widget-right-0-desktop-chrome.png
Binary file modified test/screenshots/standard-stopped-widget-right-0-mobile-android.png
Binary file modified test/screenshots/standard-stopped-widget-right-0-mobile-ios.png
Binary file modified test/screenshots/standard-stopped-widget-right-50-mobile-ios.png
Binary file modified test/screenshots/standard-stopped-widget-right-auto-mobile-ios.png
Binary file modified test/screenshots/video-paused-advert-mobile-android.png
Binary file modified test/screenshots/video-paused-advert-mobile-ios.png
Binary file modified test/screenshots/video-paused-advert-no-image-mobile-android.png
Binary file modified test/screenshots/video-paused-advert-no-image-mobile-ios.png
Binary file modified test/screenshots/video-paused-advert-playlist-mobile-android.png
Binary file modified test/screenshots/video-paused-advert-playlist-mobile-ios.png
Binary file modified test/screenshots/video-paused-advert-widget-auto-0-mobile-ios.png
Binary file modified test/screenshots/video-paused-advert-widget-auto-50-mobile-ios.png
Binary file modified test/screenshots/video-paused-advert-widget-right-0-mobile-ios.png
Binary file modified test/screenshots/video-paused-download-mobile-android.png
Binary file modified test/screenshots/video-paused-download-mobile-ios.png
Binary file modified test/screenshots/video-paused-download-no-logo-mobile-android.png
Binary file modified test/screenshots/video-paused-download-no-logo-mobile-ios.png
Binary file modified test/screenshots/video-paused-mobile-android.png
Loading

0 comments on commit 6573c1c

Please sign in to comment.