Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSP-839: Add Support for Content-Disposition #839

Merged
merged 18 commits into from
Oct 15, 2021
Merged

GSP-839: Add Support for Content-Disposition #839

merged 18 commits into from
Oct 15, 2021

Conversation

Joey-1445601153
Copy link
Contributor

Draft pr of GSP for Add Support for Content-Disposition

@Xuanwo Xuanwo changed the title Add Support for Content-Disposition GSP-839: Add Support for Content-Disposition Oct 13, 2021
@Joey-1445601153 Joey-1445601153 marked this pull request as ready for review October 14, 2021 03:47
@Xuanwo Xuanwo mentioned this pull request Oct 14, 2021
Closed
@JinnyYi
Copy link
Contributor

JinnyYi commented Oct 14, 2021

The file should be renamed to 839-add-support-for-content-disposition.md for consistency.

@Joey-1445601153 Joey-1445601153 mentioned this pull request Oct 15, 2021
Closed
1 task
@Joey-1445601153 @Xuanwo
Update docs/rfcs/839-add-support-for-content-disposition.md
a64f119 
Co-authored-by: Xuanwo <github@xuanwo.io>
@JinnyYi JinnyYi merged commit a017324 into beyondstorage:master Oct 15, 2021
@JinnyYi JinnyYi mentioned this pull request Oct 15, 2021
Open
24 tasks
@BeyondRobot BeyondRobot mentioned this pull request Oct 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo left review comments

@JinnyYi JinnyYi JinnyYi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Joey-1445601153 @JinnyYi @Xuanwo @zhangjiayu2132