getAbsPath in service works poorly

[junaire]

I found there is something wrong with our current getAbsPath implementation:

• Why it just simply splice workDir and path without / ?
• It doesn't check the input, so it might splice workDir and absolute path again, which means it can be easily misused.

Is there anything wrong with getRelPath too?

[Xuanwo]

getAbsPath and getRelPath are designed to be implemented by the service itself. Maybe the problem is introduced by borrowing code from other services directly? It's OK to refactor getAbsPath and getRelPath.

[junaire]

getAbsPath and getRelPath are designed to be implemented by the service itself. Maybe the problem is introduced by borrowing code from other services directly? It's OK to refactor getAbsPath and getRelPath.

Got it.